----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19968/#review39426 -----------------------------------------------------------
Ship it! Looks good, as long as the broad approach is approved. - Dominic Hamon On April 2, 2014, 5:06 p.m., Adam B wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19968/ > ----------------------------------------------------------- > > (Updated April 2, 2014, 5:06 p.m.) > > > Review request for mesos and Dominic Hamon. > > > Bugs: MESOS-1181 > https://issues.apache.org/jira/browse/MESOS-1181 > > > Repository: mesos-git > > > Description > ------- > > Enabled whitespace/end_of_line rule for cpplint, which covers the following: > 'Line ends in whitespace. Consider deleting these extra spaces.' > > > Diffs > ----- > > 3rdparty/libprocess/src/decoder.hpp 88da57f > 3rdparty/libprocess/src/httpd.cpp 4f4ab1b > 3rdparty/libprocess/src/process.cpp 9654c04 > src/common/date_utils.hpp 085c1ce > src/common/factory.hpp 94056f6 > support/mesos-style.py edd41f926d6df30513f8fa6c928960e6495af70a > > Diff: https://reviews.apache.org/r/19968/diff/ > > > Testing > ------- > > Ran mesos-style.py over entire source base with whitespace/end_of_line > enabled. > > > Thanks, > > Adam B > >
