> On April 3, 2014, 3:51 p.m., Dominic Hamon wrote: > > src/tests/registrar_tests.cpp, line 291 > > <https://reviews.apache.org/r/19761/diff/2/?file=548409#file548409line291> > > > > can you inherit from Registrar_Test and just change the storage?
RegistrarTest also inherits TestWithParam<T> but with a different T. class RegistrarTest : public ::testing::TestWithParam<bool> class Registrar_BENCHMARK_Test : public ::testing::TestWithParam<int> Having Registrar_BENCHMARK_Test inherit from RegistrarTest confuses INSTANTIATE_TEST_CASE_P about the argument type. Given the small amount the code duplication the fact that factoring out the common logic may not actually reduce the code size I think it's better to avoid it. - Jiang Yan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19761/#review39484 ----------------------------------------------------------- On April 3, 2014, 3:28 p.m., Jiang Yan Xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19761/ > ----------------------------------------------------------- > > (Updated April 3, 2014, 3:28 p.m.) > > > Review request for mesos, Ben Mahler and Vinod Kone. > > > Bugs: MESOS-1155 > https://issues.apache.org/jira/browse/MESOS-1155 > > > Repository: mesos-git > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/tests/registrar_tests.cpp 67c26aad8185f1328a7eb05c993ed14d47dc0664 > > Diff: https://reviews.apache.org/r/19761/diff/ > > > Testing > ------- > > mesos-tests.sh –verbose –gtest_filter=“RegistrarTest*” > –gtest_also_run_disabled_tests > > > Thanks, > > Jiang Yan Xu > >
