----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20052/#review39657 -----------------------------------------------------------
Ship it! src/slave/containerizer/mesos_containerizer.cpp <https://reviews.apache.org/r/20052/#comment72222> I guess this is possible if a destroy occurred while the launch was happening? Is it worth a brief comment above? Also, are there other places that are susceptible? - Benjamin Hindman On April 4, 2014, 9:54 p.m., Ian Downes wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20052/ > ----------------------------------------------------------- > > (Updated April 4, 2014, 9:54 p.m.) > > > Review request for mesos, Ben Mahler, Tobi Knaup, and Vinod Kone. > > > Bugs: MESOS-1193 > https://issues.apache.org/jira/browse/MESOS-1193 > > > Repository: mesos-git > > > Description > ------- > > Replace CHECK with Failure for exec in MesosContainerizer > > > Diffs > ----- > > src/slave/containerizer/mesos_containerizer.cpp > c819c97d96d232a1de3c1ed2fc848bebf66981f7 > > Diff: https://reviews.apache.org/r/20052/diff/ > > > Testing > ------- > > none > > > Thanks, > > Ian Downes > >
