----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19702/#review39716 -----------------------------------------------------------
configure.ac <https://reviews.apache.org/r/19702/#comment72329> I use something like to add the include path. PKG_CHECK_MODULES(LIBNL, libnl-3.0 >= 3.2.8 libnl-route-3.0 libnl-genl-3.0) AC_SUBST(LIBNL_CFLAGS) AC_SUBST(LIBNL_LIBS) Have a look at 3.1 and 3.2 on this page: https://www.flameeyes.eu/autotools-mythbuster/pkgconfig/pkg_check_modules.html src/linux/routing.hpp <https://reviews.apache.org/r/19702/#comment72339> reason for externs? I don't think you need to use extern unless there is a _linkage_ issue? Same for the rest of this file. src/linux/routing.hpp <https://reviews.apache.org/r/19702/#comment72340> s/links/link src/linux/routing.hpp <https://reviews.apache.org/r/19702/#comment72342> What is the inclusiveness for Value::Range? [begin, end]? Should we make this the same to avoid inconsistency? Also conversion from Value::Range could be made more straightforward? src/linux/routing.hpp <https://reviews.apache.org/r/19702/#comment72343> let's promote the comment about inclusiveness as a class level comment. src/linux/routing.hpp <https://reviews.apache.org/r/19702/#comment72344> s/ehe/the src/linux/routing.hpp <https://reviews.apache.org/r/19702/#comment72346> && in the front or end of the line? src/linux/routing.hpp <https://reviews.apache.org/r/19702/#comment72347> I am curious about the reason for mixing two orders here? src/linux/routing.hpp <https://reviews.apache.org/r/19702/#comment72348> I am curious about the reason for mixing network and host orders here? src/linux/routing.hpp <https://reviews.apache.org/r/19702/#comment72350> for create/update and maybe other functions, 'filter not found' isn't the only reason they fail. - Chi Zhang On April 7, 2014, 6:25 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19702/ > ----------------------------------------------------------- > > (Updated April 7, 2014, 6:25 p.m.) > > > Review request for mesos, Benjamin Hindman, Chi Zhang, Ian Downes, Vinod > Kone, and Cong Wang. > > > Repository: mesos-git > > > Description > ------- > > See summary. It's reviewable. > > > Diffs > ----- > > configure.ac c1de6d7 > src/Makefile.am 95f133d > src/linux/routing.hpp PRE-CREATION > src/linux/routing.cpp PRE-CREATION > src/tests/routing_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/19702/diff/ > > > Testing > ------- > > make check > > sudo make check > > > Thanks, > > Jie Yu > >
