----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20137/#review39898 -----------------------------------------------------------
src/linux/cgroups.cpp <https://reviews.apache.org/r/20137/#comment72644> what's the benefit of overloading the oom_control name here? It seems that you could make 'enable' an option and return a Try<bool> to roll the two methods together. - Dominic Hamon On April 8, 2014, 3:17 p.m., Ian Downes wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20137/ > ----------------------------------------------------------- > > (Updated April 8, 2014, 3:17 p.m.) > > > Review request for mesos, Ben Mahler and Vinod Kone. > > > Bugs: MESOS-1178 > https://issues.apache.org/jira/browse/MESOS-1178 > > > Repository: mesos-git > > > Description > ------- > > Added cgroups::memory::oom_control and cgroups::memory::listen. > > cgroups::memory::oom_control will not write to the control file unless it > needs to change the state. > > > Diffs > ----- > > src/linux/cgroups.hpp 5a5735721fb9f051eee661edb08d1cdaa163d0f3 > src/linux/cgroups.cpp 8202c282f580d027a60ded2081962e96e4860f60 > src/slave/containerizer/isolators/cgroups/mem.cpp > 9e9c55e37f499898196b61cc586cb0e49feabf56 > src/tests/cgroups_tests.cpp 6ba9de622953e158feadaa9950618b0b13c9e832 > > Diff: https://reviews.apache.org/r/20137/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Ian Downes > >
