----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19951/#review39948 -----------------------------------------------------------
Ship it! Ian, can you commit this? src/tests/cgroups_tests.cpp <https://reviews.apache.org/r/19951/#comment72723> How about // Check the test cgroup now only contains all the child threads. src/linux/cgroups.cpp <https://reviews.apache.org/r/19951/#comment72722> woah. i thought this was not supported by kernels < 3.10 !? - Vinod Kone On April 3, 2014, 10:59 p.m., Ian Downes wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19951/ > ----------------------------------------------------------- > > (Updated April 3, 2014, 10:59 p.m.) > > > Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone. > > > Repository: mesos-git > > > Description > ------- > > Use cgroups.proc (rather than tasks) so all threads in the pid's threadgroup > are assigned. > > Documentation/cgroups/cgroups.txt: > "You can use the cgroup.procs file instead of the tasks file to move all > threads in a threadgroup at once. " > > Added a test to verify all threads are assigned. > > This obviates the recently introduced assignAllThreads and thus it has been > removed. > > > Diffs > ----- > > src/linux/cgroups.hpp 5a5735721fb9f051eee661edb08d1cdaa163d0f3 > src/linux/cgroups.cpp 8202c282f580d027a60ded2081962e96e4860f60 > src/slave/slave.cpp a356f5f0a0a43581c6380df1bc9b15fd228b3015 > src/tests/cgroups_tests.cpp 6ba9de622953e158feadaa9950618b0b13c9e832 > src/tests/cluster.hpp 11684d99c6a4e623dd5ff9977d210de59f33f5cd > > Diff: https://reviews.apache.org/r/19951/diff/ > > > Testing > ------- > > make check # Linux > > > Thanks, > > Ian Downes > >
