> On April 10, 2014, 12:52 p.m., Benjamin Hindman wrote: > > src/slave/slave.hpp, line 421 > > <https://reviews.apache.org/r/20219/diff/1/?file=554472#file554472line421> > > > > You have in the description of this review "an option type ... is > > needed when the > > executor info isn't known up-front and the executor resources therefore > > cannot be known > > until after the containerizer has launched the container." Something > > along these lines would be great for posterity as a comment here! ;)
Great point - thanks! > On April 10, 2014, 12:52 p.m., Benjamin Hindman wrote: > > src/slave/slave.cpp, lines 3254-3256 > > <https://reviews.apache.org/r/20219/diff/1/?file=554473#file554473line3254> > > > > Can we move the CHECK_SOME down here? > > > > launchedTasks[task.task_id()] = t; > > > > CHECK_SOME(resources); > > resources = resources.get() + task.resources(); > > > > return t; You bet! > On April 10, 2014, 12:52 p.m., Benjamin Hindman wrote: > > src/slave/slave.cpp, lines 3274-3275 > > <https://reviews.apache.org/r/20219/diff/1/?file=554473#file554473line3274> > > > > Swap these two? Done :) - Niklas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20219/#review40070 ----------------------------------------------------------- On April 10, 2014, 1:58 p.m., Niklas Nielsen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20219/ > ----------------------------------------------------------- > > (Updated April 10, 2014, 1:58 p.m.) > > > Review request for mesos, Ian Downes and Vinod Kone. > > > Repository: mesos-git > > > Description > ------- > > Yet another split out of the task-info RR (r19795/r18403) which turns > Executor::resources into an option type. It is needed when the > executor info isn't known up-front (the main motivation behind the > task-info RR) and the executor resources therefore cannot be known > until after the containerizer has launched the container. > > > Diffs > ----- > > src/slave/http.cpp 594032d > src/slave/slave.hpp 08f6005 > src/slave/slave.cpp cddb241 > > Diff: https://reviews.apache.org/r/20219/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Niklas Nielsen > >
