----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18381/#review40185 -----------------------------------------------------------
Ping. Vinod, please review. Thanks! - Adam B On April 2, 2014, 9:44 p.m., Adam B wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18381/ > ----------------------------------------------------------- > > (Updated April 2, 2014, 9:44 p.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: MESOS-804 > https://issues.apache.org/jira/browse/MESOS-804 > > > Repository: mesos-git > > > Description > ------- > > Added authentication support for slaves. > Fixes MESOS-804. > > Open Questions: > - Should AuthenticateMessage be replaced with AuthenticateFrameworkMessage, > or specify an Authenticatee type as coded here? > - When multiple entries for the same principal exist in the credentials file, > only the last entry is used. Acceptable behavior, but shouldn't this be > documented? > > > Diffs > ----- > > include/mesos/mesos.proto 37f8a7f > src/master/flags.hpp 024f86d > src/master/master.hpp b6b9983 > src/master/master.cpp 5d0ddb0 > src/messages/messages.proto bba17a9 > src/sasl/authenticatee.hpp 42a4eba > src/sasl/common.hpp PRE-CREATION > src/sched/sched.cpp 3684cfe > src/slave/flags.hpp d5c54c0 > src/slave/slave.hpp 15e23ce > src/slave/slave.cpp 6d901dc > src/tests/authentication_tests.cpp 127c5e6 > src/tests/cluster.hpp 11684d9 > src/tests/mesos.cpp ae3aeee > src/tests/sasl_tests.cpp 945426d > src/tests/slave_recovery_tests.cpp 72b6d42 > > Diff: https://reviews.apache.org/r/18381/diff/ > > > Testing > ------- > > make check; manually tested flatfile slave authentication success/failure. > Added new slave authentication unit tests in authentication_tests.cpp. > > > Thanks, > > Adam B > >
