----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19180/#review40254 -----------------------------------------------------------
Ship it! Ship It! - Adam B On April 14, 2014, 1 a.m., Chengwei Yang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19180/ > ----------------------------------------------------------- > > (Updated April 14, 2014, 1 a.m.) > > > Review request for mesos, Adam B, Ben Mahler, Jie Yu, Niklas Nielsen, and > Vinod Kone. > > > Bugs: MESOS-1093 > https://issues.apache.org/jira/browse/MESOS-1093 > > > Repository: mesos-git > > > Description > ------- > > Fix mesos command parsing help > > Without this patch, "mesos help --help" will output below > > Not expecting '--help' before command > Usage: mesos <command> [OPTIONS] > > Available commands: > help > resolve > cat > scp > log > tail > execute > ps > local > resolve > cat > scp > log > tail > execute > ps > local > > Apparently all available commands printed twice, the "mesos help help" > will print available commands 3 times. > > The root cause is the directory contains available mesos commands are > added more than one times when recursive to main() again. > > Idea comes from Adam B. > > Review: https://reviews.apache.org/r/19180 > > > Diffs > ----- > > src/cli/mesos.cpp 171a707cd2ba2348898e7fbe8fe9f0634edd6d86 > > Diff: https://reviews.apache.org/r/19180/diff/ > > > Testing > ------- > > done? > > > Thanks, > > Chengwei Yang > >
