> On April 9, 2014, 10:34 p.m., Vinod Kone wrote: > > src/master/master.hpp, line 388 > > <https://reviews.apache.org/r/19857/diff/1/?file=551531#file551531line388> > > > > s/reregistrationTimer/slaveReregsistrationTimer/ ? > > > > or pull this inside Slaves struct?
Good call, I pulled this into the Slaves struct. > On April 9, 2014, 10:34 p.m., Vinod Kone wrote: > > src/master/master.cpp, line 763 > > <https://reviews.apache.org/r/19857/diff/1/?file=551532#file551532line763> > > > > How about making this configurable and have the current value as the > > default? Maybe another review and/or a TODO? Sounds good, added a TODO. I wonder if we'll want to make this any different than the total health check timeout. There may be value in separating these numbers but it's also more complex to configure. - Ben ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19857/#review39953 ----------------------------------------------------------- On April 7, 2014, 7:03 p.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19857/ > ----------------------------------------------------------- > > (Updated April 7, 2014, 7:03 p.m.) > > > Review request for mesos, Benjamin Hindman and Vinod Kone. > > > Bugs: MESOS-764 > https://issues.apache.org/jira/browse/MESOS-764 > > > Repository: mesos-git > > > Description > ------- > > This allows us to impose a limit on the number of slaves we will remove after > the timer expires. > > > Diffs > ----- > > src/master/master.hpp fef59c9971fcb3a5a33d7c94210b87edacb5719b > src/master/master.cpp 3c3c989543167afb7d368a19a16457ed00e6be0c > > Diff: https://reviews.apache.org/r/19857/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Ben Mahler > >
