----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19762/#review40338 -----------------------------------------------------------
Ship it! Looks great, thanks Yan! src/master/registrar.hpp <https://reviews.apache.org/r/19762/#comment73342> Probably we don't need this much detail here since we've already explained it below, you could just say: "Make Operation generic so that we can apply them against a generic "batch operation applier" abstraction, see TODO below for more details." src/master/registrar.hpp <https://reviews.apache.org/r/19762/#comment73341> Double quotes here but single quotes above? src/master/registrar.hpp <https://reviews.apache.org/r/19762/#comment73340> s/to us/us to/ s/new features/new state variables/ And please end with period. :) src/master/registrar.hpp <https://reviews.apache.org/r/19762/#comment73343> Rather than naming it, maybe just describe what it will do: Add a generic abstraction for applying batches of operations against State Variables, the Registrar and other components could leverage this. This abstraction would be templatized to take the type, along with any accumulators: ... - Ben Mahler On April 14, 2014, 6:49 p.m., Jiang Yan Xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19762/ > ----------------------------------------------------------- > > (Updated April 14, 2014, 6:49 p.m.) > > > Review request for mesos, Benjamin Hindman and Ben Mahler. > > > Bugs: MESOS-1155 > https://issues.apache.org/jira/browse/MESOS-1155 > > > Repository: mesos-git > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/master/master.hpp fef59c9971fcb3a5a33d7c94210b87edacb5719b > src/master/registrar.hpp 0d659c57d55f7d054e106477c814d921479e3177 > src/master/registrar.cpp 9c0537d86036dec3e6a0fac84e167d9131242e0c > > Diff: https://reviews.apache.org/r/19762/diff/ > > > Testing > ------- > > mesos-tests.sh –verbose –gtest_filter=“RegistrarTest*” > –gtest_also_run_disabled_tests > On test machines this reduces the time for applying 20,000 (re)admit > operations from 30secs to < 100ms > > > Thanks, > > Jiang Yan Xu > >
