----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20140/#review40461 -----------------------------------------------------------
Ship it! Ship It! - Vinod Kone On April 9, 2014, 12:06 a.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20140/ > ----------------------------------------------------------- > > (Updated April 9, 2014, 12:06 a.m.) > > > Review request for mesos, Benjamin Hindman and Vinod Kone. > > > Bugs: MESOS-783 > https://issues.apache.org/jira/browse/MESOS-783 > > > Repository: mesos-git > > > Description > ------- > > MESOS-783 was fixed during the registrar implementation, however we must > ensure that we only reply with TASK_LOST when a non-strict Registry is in > use. Otherwise the slave containing this task may still re-register, exposing > inconsistent state between the scheduler and the master. > > There's a question here as to whether we simply ignore whether the registry > operations are strict, since in the past we used to send TASK_LOST when we > could not find the task. > > > Diffs > ----- > > src/master/master.cpp 3c3c989543167afb7d368a19a16457ed00e6be0c > > Diff: https://reviews.apache.org/r/20140/diff/ > > > Testing > ------- > > make check > > Integration tests for reconciliation and killTask will follow! > > > Thanks, > > Ben Mahler > >
