----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20402/#review40553 -----------------------------------------------------------
This is awesome Tobi! One question: Can we actually still use protobuf.jar with the example frameworks? My expectation is that existing frameworks should be able to continue to use their protobuf dependencies and we've just shaded all use of protobuf from them. That way we don't require frameworks/users to use org.apache.mesos.com.google.protobuf... but perhaps I'm missing something here? Assuming that works, we can drop all the changes to Java example code (which should make this diff even simpler) since that will stand as a reference for how we expect people to still use Mesos. Also, it's great to see the configure check and apparently our build machines don't have maven!? I'll look into that for you ASAP. - Benjamin Hindman On April 16, 2014, 4:15 a.m., Tobi Knaup wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20402/ > ----------------------------------------------------------- > > (Updated April 16, 2014, 4:15 a.m.) > > > Review request for mesos. > > > Bugs: MESOS-1212 > https://issues.apache.org/jira/browse/MESOS-1212 > > > Repository: mesos-git > > > Description > ------- > > Use Maven to build the Mesos jars, and include shaded protbuf jar. > No longer builds a custom protobuf jar but relies on Maven. > > NOTE: #20329 (shading) is a breaking change for JVM frameworks which use the > com.google.protobuf namespace. These need to change to > org.apache.mesos.com.google.protobuf. > > Includes the dependent patch from https://reviews.apache.org/r/20329/ which > I'll delete once that's merged. > > > Diffs > ----- > > configure.ac c1de6d7 > src/Makefile.am 560b4c7 > src/examples/java/TestExceptionFramework.java 464b3b0 > src/examples/java/TestFramework.java 65ee2dc > src/examples/java/TestMultipleExecutorsFramework.java 6846959 > src/examples/java/test-exception-framework.in 26617e2 > src/examples/java/test-executor.in 8b27a37 > src/examples/java/test-framework.in bbdc1ed > src/examples/java/test-log.in b7e69e4 > src/examples/java/test-multiple-executors-framework.in eb8edf6 > src/java/mesos.pom.in 8f9b747 > > Diff: https://reviews.apache.org/r/20402/diff/ > > > Testing > ------- > > make check > make maven-install > > > Thanks, > > Tobi Knaup > >
