> On April 17, 2014, 12:23 a.m., Dominic Hamon wrote: > > this is used in the cpp only so there's no need for it to be added to the > > public header.
Yeah, I saw that, maybe make it a static function is better. - Chengwei ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20403/#review40562 ----------------------------------------------------------- On April 16, 2014, 12:35 p.m., Chengwei Yang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20403/ > ----------------------------------------------------------- > > (Updated April 16, 2014, 12:35 p.m.) > > > Review request for mesos, Benjamin Hindman and Vinod Kone. > > > Repository: mesos-git > > > Description > ------- > > Add all model() declaration into src/common/http.hpp > > There are four overloading function model() but only three of them > declared in src/common/http.hpp and used. > > In case the last one will be used in future, declare it in > src/common/http.hpp too. > > > Diffs > ----- > > src/common/http.hpp 717bbe99f2ec51a2d1b90730eb19cd54cc82b897 > > Diff: https://reviews.apache.org/r/20403/diff/ > > > Testing > ------- > > make passed > > > Thanks, > > Chengwei Yang > >
