----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20308/#review40618 -----------------------------------------------------------
3rdparty/libprocess/include/process/queue.hpp <https://reviews.apache.org/r/20308/#comment73682> This should be: future = data->promises.back()->future() Or am I missing something? 3rdparty/libprocess/include/process/queue.hpp <https://reviews.apache.org/r/20308/#comment73680> I am wondering whether this could cause some subtle deadlock issues. For example: q.put() { acquire(q.lock); ... promise->set() { onAnyCallback() { q.put() { acquire(q.lock); } } } } - Jie Yu On April 14, 2014, 5:47 a.m., Benjamin Hindman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20308/ > ----------------------------------------------------------- > > (Updated April 14, 2014, 5:47 a.m.) > > > Review request for mesos and Jie Yu. > > > Repository: mesos-git > > > Description > ------- > > See summary. > > > Diffs > ----- > > 3rdparty/libprocess/Makefile.am d707ad759dacd16e0177e14f1bf5ece9e4ce2491 > 3rdparty/libprocess/include/process/queue.hpp PRE-CREATION > 3rdparty/libprocess/src/tests/queue_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/20308/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Hindman > >
