----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20470/#review40728 -----------------------------------------------------------
Ship it! src/zookeeper/group.cpp <https://reviews.apache.org/r/20470/#comment73872> This comment sounds like something handled by an 'if' condition, maybe say: // In order to be retrying, we should be at least CONNECTED. Up to you. - Ben Mahler On April 18, 2014, 12:13 a.m., Jiang Yan Xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20470/ > ----------------------------------------------------------- > > (Updated April 18, 2014, 12:13 a.m.) > > > Review request for mesos and Ben Mahler. > > > Bugs: MESOS-1214 > https://issues.apache.org/jira/browse/MESOS-1214 > > > Repository: mesos-git > > > Description > ------- > > - Retry can be invoked when the Group is in any state but DISCONNECTED. > > > Diffs > ----- > > src/zookeeper/group.cpp cff59976259499ea03db8f35cb2b40674b5e4b53 > > Diff: https://reviews.apache.org/r/20470/diff/ > > > Testing > ------- > > make check. > > > Thanks, > > Jiang Yan Xu > >
