----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20430/#review40751 -----------------------------------------------------------
Bad patch! Reviews applied: [20430] Failed command: git apply --index 20430.patch Error: error: patch failed: src/tests/cluster.hpp:20 error: src/tests/cluster.hpp: patch does not apply - Mesos ReviewBot On April 16, 2014, 10:17 p.m., Ian Downes wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20430/ > ----------------------------------------------------------- > > (Updated April 16, 2014, 10:17 p.m.) > > > Review request for mesos, Ben Mahler, Jie Yu, and Vinod Kone. > > > Bugs: MESOS-976 > https://issues.apache.org/jira/browse/MESOS-976 > > > Repository: mesos-git > > > Description > ------- > > Many tests (in particular slave recovery tests) leave containers running at > the end of a test. This patch extends Cluster::Slaves::shutdown to query and > destroy the containers for any slaves in the cluster, ensuring isolators can > properly clean up everything. > > Note: This is not done for slaves that are stopped (so we can actually do > slave recovery tests!) so any test that completes without slaves but with > containers still running must do this step manually - see the two modified > tests. > > > Diffs > ----- > > src/tests/cluster.hpp 8479fe370d5a64cb2827b69b6f0c626b9d156d66 > src/tests/slave_recovery_tests.cpp 72b6d42f0895f10fed041a5a1351e79b003e2d1b > > Diff: https://reviews.apache.org/r/20430/diff/ > > > Testing > ------- > > > Thanks, > > Ian Downes > >
