----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20047/#review40803 -----------------------------------------------------------
3rdparty/libprocess/include/process/statistics.hpp <https://reviews.apache.org/r/20047/#comment73971> Unused? 3rdparty/libprocess/include/process/statistics.hpp <https://reviews.apache.org/r/20047/#comment73972> This probably seems inconsistent because our constructors use _ prefixes (which I don't like ;)), but normally for variables like this we'll use an _ suffix so as to mean "values prime", since C++ doesn't let us write "values'" :) 3rdparty/libprocess/include/process/statistics.hpp <https://reviews.apache.org/r/20047/#comment73973> s/v/value/? 3rdparty/libprocess/include/process/statistics.hpp <https://reviews.apache.org/r/20047/#comment73970> Looks like this could leverage the 'Percentage' abstraction I mentioned in some earlier patches, because there's some ambiguity in the caller as to whether they need to call this with [0..1] or [0..100]. Could we add a TODO for that? But taking a step back, do we need to keep around all of this data? Could we just pre-compute a 'Percentiles' struct in the constructor which provides p50, p90, p99, p99.9, p99.99? We'll likely want to expose a consistent set of percentiles for all metrics anyway, right? Would be great to add a TODO that captures our intent to eventually add real-time histograms as well if it proves to be needed for efficiency. - Ben Mahler On April 16, 2014, 8:56 p.m., Dominic Hamon wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20047/ > ----------------------------------------------------------- > > (Updated April 16, 2014, 8:56 p.m.) > > > Review request for mesos, Benjamin Hindman and Ben Mahler. > > > Bugs: MESOS-1036 > https://issues.apache.org/jira/browse/MESOS-1036 > > > Repository: mesos-git > > > Description > ------- > > see summary > > > Diffs > ----- > > 3rdparty/libprocess/Makefile.am d707ad759dacd16e0177e14f1bf5ece9e4ce2491 > 3rdparty/libprocess/include/process/statistics.hpp > a4f1db3a8a219c39193a1d237477f0350e47e681 > 3rdparty/libprocess/src/process.cpp > 9654c0437edb43cff65dbefdf08dee9e18ef96ab > 3rdparty/libprocess/src/statistics.cpp > 75aac4074d33cb5054da6c8b0bd4a890c2eaf80e > 3rdparty/libprocess/src/tests/statistics_tests.cpp > 3521bd565dae8fcbba464f2539b3b14a37a037f0 > 3rdparty/libprocess/src/timeseries.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/20047/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Dominic Hamon > >
