----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20505/#review40829 -----------------------------------------------------------
Ship it! src/slave/containerizer/mesos_containerizer.cpp <https://reviews.apache.org/r/20505/#comment74017> Can you add a comment here on why we are not using 'resources' map here, so that someone in the future doesn't come around and try to change it. - Vinod Kone On April 18, 2014, 10:40 p.m., Ian Downes wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20505/ > ----------------------------------------------------------- > > (Updated April 18, 2014, 10:40 p.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: MESOS-1221 > https://issues.apache.org/jira/browse/MESOS-1221 > > > Repository: mesos-git > > > Description > ------- > > Changed slave to start monitoring container usage after a slave re-registers > following slave recovery. > > Added a test to verify that a containerizer correctly reports resource limits > after recovery. > > > Diffs > ----- > > src/slave/containerizer/mesos_containerizer.cpp > 1ce41d71eb13582b46d240d48f0508bdc3e7ef10 > src/slave/slave.cpp d6ec87c2232c2172f471ae30711b5da1c7050570 > src/tests/slave_recovery_tests.cpp 72b6d42f0895f10fed041a5a1351e79b003e2d1b > > Diff: https://reviews.apache.org/r/20505/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Ian Downes > >
