----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20504/#review40832 -----------------------------------------------------------
3rdparty/libprocess/include/process/process.hpp <https://reviews.apache.org/r/20504/#comment74031> It might be worth not calling this 'unlink' as it offers differing functionality from what I would expect an 'unlink' function to provide, namely: http://www.erlang.org/doc/man/erlang.html#unlink-1 Should this remove the existing link before we send the spoofed event? Otherwise you could receive duplicate exit events? - Ben Mahler On April 18, 2014, 10:54 p.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20504/ > ----------------------------------------------------------- > > (Updated April 18, 2014, 10:54 p.m.) > > > Review request for mesos, Benjamin Hindman and Ben Mahler. > > > Bugs: MESOS-1059 > https://issues.apache.org/jira/browse/MESOS-1059 > > > Repository: mesos-git > > > Description > ------- > > This is used in the subsequent review. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/process.hpp > d6bdccfccaad79cc9bc29f03a6cb9fa8550ccc64 > 3rdparty/libprocess/src/process.cpp > 9654c0437edb43cff65dbefdf08dee9e18ef96ab > 3rdparty/libprocess/src/tests/process_tests.cpp > ff0ee757c75732a2a99b5dac1aa43a7db8a60158 > > Diff: https://reviews.apache.org/r/20504/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Vinod Kone > >
