> On April 18, 2014, 5:55 p.m., Ben Mahler wrote: > > 3rdparty/libprocess/src/process.cpp, lines 1556-1571 > > <https://reviews.apache.org/r/20047/diff/10/?file=562625#file562625line1556> > > > > Feel free to just remove this.
elsewhere in this file (597) this is being set to 1 day, which then overrides the libprocess default of 2 weeks. Given our concern with memory usage for statistics do you think it's worth changing the libprocess default to 1 day before removing this? Are we sure this env var isn't being used? - Dominic ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20047/#review40835 ----------------------------------------------------------- On April 18, 2014, 4:24 p.m., Dominic Hamon wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20047/ > ----------------------------------------------------------- > > (Updated April 18, 2014, 4:24 p.m.) > > > Review request for mesos, Benjamin Hindman and Ben Mahler. > > > Bugs: MESOS-1036 > https://issues.apache.org/jira/browse/MESOS-1036 > > > Repository: mesos-git > > > Description > ------- > > see summary > > > Diffs > ----- > > 3rdparty/libprocess/Makefile.am d707ad759dacd16e0177e14f1bf5ece9e4ce2491 > 3rdparty/libprocess/include/process/statistics.hpp > a4f1db3a8a219c39193a1d237477f0350e47e681 > 3rdparty/libprocess/src/process.cpp > 9654c0437edb43cff65dbefdf08dee9e18ef96ab > 3rdparty/libprocess/src/statistics.cpp > 75aac4074d33cb5054da6c8b0bd4a890c2eaf80e > 3rdparty/libprocess/src/tests/statistics_tests.cpp > 3521bd565dae8fcbba464f2539b3b14a37a037f0 > 3rdparty/libprocess/src/timeseries.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/20047/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Dominic Hamon > >
