----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18600/#review41090 -----------------------------------------------------------
Ship it! src/log/recover.cpp <https://reviews.apache.org/r/18600/#comment74495> Can you add a similar comment as in 'timedout' here? That is let's reiterate the role 'terminating' plays and that it gets set in 'discard'. - Benjamin Hindman On April 21, 2014, 10:17 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18600/ > ----------------------------------------------------------- > > (Updated April 21, 2014, 10:17 p.m.) > > > Review request for mesos, Benjamin Hindman and Ben Mahler. > > > Bugs: MESOS-984 > https://issues.apache.org/jira/browse/MESOS-984 > > > Repository: mesos-git > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/log/log.hpp 6787c80 > src/log/log.cpp 9dd992f > src/log/recover.hpp 634bc06 > src/log/recover.cpp 688da5f > src/tests/log_tests.cpp 4f08927 > > Diff: https://reviews.apache.org/r/18600/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jie Yu > >
