----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20572/#review41091 -----------------------------------------------------------
Ship it! src/master/flags.hpp <https://reviews.apache.org/r/20572/#comment74500> I think you can call this just 'slave_reregister_timeout' because the only slave reregistration is after master failover, i.e., on master recovery, but the explicitness isn't so bad either (just verbose). src/master/main.cpp <https://reviews.apache.org/r/20572/#comment74496> Let's not prefix it with '.' so that it isn't hidden from people in our filesystem. As for name, what about 'log_storage' to match the registry flag? Or 'registry_log_storage', or something similar? src/master/main.cpp <https://reviews.apache.org/r/20572/#comment74498> We should make sure that 'zk' is not the empty string (or better make 'zk' be an Option). src/tests/cluster.hpp <https://reviews.apache.org/r/20572/#comment74497> Hmm, weird scheme here ... I don't know why the initializer can't assume the path that we gave it was sufficient and it shouldn't have to append '.log'. - Benjamin Hindman On April 22, 2014, 8:02 p.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20572/ > ----------------------------------------------------------- > > (Updated April 22, 2014, 8:02 p.m.) > > > Review request for mesos, Ben Mahler and Jiang Yan Xu. > > > Bugs: MESOS-1226 > https://issues.apache.org/jira/browse/MESOS-1226 > > > Repository: mesos-git > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/master/constants.hpp 27ae4f89cfd1ddb7db287d650af160a690f93c26 > src/master/constants.cpp ed966bc5bcc4dbb0f96b966efe33f179723c6759 > src/master/flags.hpp acf39636bca8b259763d2679d7cd7a946a8aa043 > src/master/main.cpp ec23781d2a1e687af031c060059de69079b179b4 > src/master/master.cpp 0335b3416ee1c4d14a70e018ad9174b465035c5f > src/state/log.hpp e25d1e5e1daf9a5a8cd6b7c6c9c95c38b58f892d > src/tests/cluster.hpp 1862fe89a6c5897755133232d133dbf3664ed10a > src/tests/mesos.cpp a9844e4cfef2eecbb30ca4bf1fa59d62edf93569 > src/zookeeper/group.cpp bdebc48e8ca793fa58cc0f9a0fc0daa5fb3a335e > > Diff: https://reviews.apache.org/r/20572/diff/ > > > Testing > ------- > > Tests upcoming. I could either do it in this review or a subsequent one if > others want to pitch in. > > > Thanks, > > Vinod Kone > >
