> On April 22, 2014, 11:57 p.m., Ben Mahler wrote: > > 3rdparty/libprocess/include/process/metrics/timer.hpp, line 76 > > <https://reviews.apache.org/r/20339/diff/8/?file=564628#file564628line76> > > > > Do you need to push in the locked section? > > Dominic Hamon wrote: > i need to get in the locked section. Otherwise some other thread could > change lastValue before the push happens.
Doesn't counter have the same issue but we've deemed it to be ok because it's racing anyway? > On April 22, 2014, 11:57 p.m., Ben Mahler wrote: > > 3rdparty/libprocess/src/tests/metrics_tests.cpp, lines 139-172 > > <https://reviews.apache.org/r/20339/diff/8/?file=564629#file564629line139> > > > > It looks like we could get away with a simpler test that uses 1 timer > > and Clock::now to ensure the relative timing is correct. > > Dominic Hamon wrote: > I tried using Clock and it seemed that the stopwatch underlying timer > didn't respect Clock changes. I may have done something wrong :) Yeah I updated this to use Clock, let me know if you see any issues! - Ben ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20339/#review41051 ----------------------------------------------------------- On April 22, 2014, 6:35 p.m., Dominic Hamon wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20339/ > ----------------------------------------------------------- > > (Updated April 22, 2014, 6:35 p.m.) > > > Review request for mesos, Benjamin Hindman and Ben Mahler. > > > Bugs: MESOS-1217 > https://issues.apache.org/jira/browse/MESOS-1217 > > > Repository: mesos-git > > > Description > ------- > > see summary. > > > Diffs > ----- > > 3rdparty/libprocess/Makefile.am 0a8a31bf107041e4dd014f81785ac27e255f29a2 > 3rdparty/libprocess/include/process/metrics/timer.hpp PRE-CREATION > 3rdparty/libprocess/src/tests/metrics_tests.cpp > abe1588c931b45a09294812974788aa74de44dd4 > > Diff: https://reviews.apache.org/r/20339/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Dominic Hamon > >
