----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20602/#review41152 -----------------------------------------------------------
Ship it! It would be great to follow up in a subsequent review and add some tests. I guess these were missing originally ... src/log/network.hpp <https://reviews.apache.org/r/20602/#comment74563> I think we should default this to the empty set. - Benjamin Hindman On April 23, 2014, 6 a.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20602/ > ----------------------------------------------------------- > > (Updated April 23, 2014, 6 a.m.) > > > Review request for mesos, Benjamin Hindman and Ben Mahler. > > > Bugs: MESOS-1231 > https://issues.apache.org/jira/browse/MESOS-1231 > > > Repository: mesos-git > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/log/log.cpp ca97144 > src/log/network.hpp 788d9eb > > Diff: https://reviews.apache.org/r/20602/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jie Yu > >
