----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19487/#review41154 -----------------------------------------------------------
configure.ac <https://reviews.apache.org/r/19487/#comment74565> reorder them to be consistent with how you did above. src/jvm/jvm.cpp <https://reviews.apache.org/r/19487/#comment74566> So is it the expectation now that the java frameworks now set this environment variable? IIUC, in the absence of the env, this will default to the jvm_library path used during mesos build which likely will be different from the jvm during runtime. Won't this break existing frameworks? Can we have a proper deprecation cycle? It is entirely possible that I misunderstood how this tooling works, so please correct me if I'm wrong. - Vinod Kone On April 23, 2014, 4:36 p.m., Timothy St. Clair wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19487/ > ----------------------------------------------------------- > > (Updated April 23, 2014, 4:36 p.m.) > > > Review request for mesos, Benjamin Hindman, Niklas Nielsen, and Till > Toenshoff. > > > Bugs: MESOS-1126 > https://issues.apache.org/jira/browse/MESOS-1126 > > > Repository: mesos-git > > > Description > ------- > > The dependency on libjvm is a "hard", requiring an link and rpath. This > causes issues when shifting between jvms. The standard practice is to use > dlopen against the $JAVA_JVM_LIBRARY location. > > MESOS-1126 > + Enable dlopen for libjvm.so > + Cleanup redundant jni inclusions > > This should make MESOS-855 a non-issue. > > > Diffs > ----- > > configure.ac c1de6d7 > src/Makefile.am a44ea42 > src/common/build.hpp 115e9cc > src/common/build.cpp eed08ed > src/jvm/jvm.cpp d3dfa75 > > Diff: https://reviews.apache.org/r/19487/diff/ > > > Testing > ------- > > make check (across both Mac and Linux) > > > Thanks, > > Timothy St. Clair > >
