----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20615/#review41159 -----------------------------------------------------------
3rdparty/libprocess/src/tests/metrics_tests.cpp <https://reviews.apache.org/r/20615/#comment74568> just pull this to the top of the file. 3rdparty/libprocess/src/tests/metrics_tests.cpp <https://reviews.apache.org/r/20615/#comment74570> Why do we need to do this only in this test and the next one? Isn't the metrics process initialized with libprocess initialization? Have we understood what the root cause of the bug (also, please attach the bug id) is? 3rdparty/libprocess/src/tests/metrics_tests.cpp <https://reviews.apache.org/r/20615/#comment74569> kill it. - Vinod Kone On April 23, 2014, 5:13 p.m., Dominic Hamon wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20615/ > ----------------------------------------------------------- > > (Updated April 23, 2014, 5:13 p.m.) > > > Review request for mesos and Vinod Kone. > > > Repository: mesos-git > > > Description > ------- > > see summary > > > Diffs > ----- > > 3rdparty/libprocess/src/tests/metrics_tests.cpp > 6f3795b33b92dd0621867e274649f8b9667ba538 > > Diff: https://reviews.apache.org/r/20615/diff/ > > > Testing > ------- > > build/3rdparty/libprocess/tests --gtest_filter='Metrics.Snapshot*' > --gtest_repeat=-1 --gtest_shuffle --gtest_break_on_failure > > > Thanks, > > Dominic Hamon > >
