> On April 23, 2014, 6:53 p.m., Ben Mahler wrote: > > src/tests/log_tests.cpp, line 2011 > > <https://reviews.apache.org/r/20618/diff/1/?file=565962#file565962line2011> > > > > Should this test be inside an ifdef for MESOS_HAS_JAVA since that's how > > the include is guarded for ZooKeeperTest?
Ben, it's inside #ifdef MESOS_HAS_JAVA guard:) - Jie ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20618/#review41185 ----------------------------------------------------------- On April 23, 2014, 6:41 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20618/ > ----------------------------------------------------------- > > (Updated April 23, 2014, 6:41 p.m.) > > > Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone. > > > Bugs: MESOS-1231 > https://issues.apache.org/jira/browse/MESOS-1231 > > > Repository: mesos-git > > > Description > ------- > > Followup for https://reviews.apache.org/r/20602/ > > See summary. > > > Diffs > ----- > > src/log/network.hpp ad9854b > src/tests/log_tests.cpp db91ef8 > > Diff: https://reviews.apache.org/r/20618/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jie Yu > >
