> On April 23, 2014, 7:44 p.m., Dominic Hamon wrote: > > src/tests/state_tests.cpp, line 61 > > <https://reviews.apache.org/r/20627/diff/1/?file=566081#file566081line61> > > > > using namespace mesos::internal::log ? > > > > then the 'Initialize' type won't be ambiguous to readers.
I liked that! Fixed it. - Jie ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20627/#review41196 ----------------------------------------------------------- On April 23, 2014, 7:41 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20627/ > ----------------------------------------------------------- > > (Updated April 23, 2014, 7:41 p.m.) > > > Review request for mesos, Benjamin Hindman, Dominic Hamon, and Vinod Kone. > > > Bugs: MESOS-1232 > https://issues.apache.org/jira/browse/MESOS-1232 > > > Repository: mesos-git > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/tests/state_tests.cpp 56feb27 > > Diff: https://reviews.apache.org/r/20627/diff/ > > > Testing > ------- > > make check > > gcc-4.4 > gcc-4.1.2 > > > Thanks, > > Jie Yu > >
