-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20632/
-----------------------------------------------------------
Review request for mesos, Ben Mahler and Vinod Kone.
Bugs: MESOS-1152
https://issues.apache.org/jira/browse/MESOS-1152
Repository: mesos-git
Description
-------
Using clone() directly for creating threads is not advised because glibc
expects thread local storage to be set up in a particular way. If a glibc
function (e.g., sleep) is called there's a race where the incorrectly set up
TLS is sometimes discovered which crashes the thread and child, ultimately
failing the test.
The MultipleThreads test has been greatly simplified to not use a forked child
and to just use pthread_create in the test. The test now only checks the number
of threads counted is correct, not their thread ids.
Diffs
-----
3rdparty/libprocess/3rdparty/stout/tests/proc_tests.cpp
8ca6d80dbbd29ba0ead6bbb8a84e794eea0e1173
Diff: https://reviews.apache.org/r/20632/diff/
Testing
-------
# gcc version 4.8.1 20130715 (Red Hat 4.8.1-4) (GCC)
./3rdparty/libprocess/3rdparty/stout-tests --gtest_repeat=1000
--gtest_filter="ProcTest*" --gtest_break_on_failure
# gcc version 4.4.7 20120313 (Red Hat 4.4.7-3) (GCC)
./3rdparty/libprocess/3rdparty/stout-tests --gtest_repeat=1000
--gtest_filter="ProcTest*" --gtest_break_on_failure
Thanks,
Ian Downes
