----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20638/#review41301 -----------------------------------------------------------
src/master/master.hpp <https://reviews.apache.org/r/20638/#comment74725> Why 'counters' instead of 'metrics'? I like the namespacing, but in the past we used 'stats' for everything, and I can't see the benefit in 'counters', 'gauges', and 'timers', since they're all just metrics. Something else I'm missing? src/tests/master_tests.cpp <https://reviews.apache.org/r/20638/#comment74726> How are these all starting at 1u? - Benjamin Hindman On April 24, 2014, 1:19 a.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20638/ > ----------------------------------------------------------- > > (Updated April 24, 2014, 1:19 a.m.) > > > Review request for mesos and Vinod Kone. > > > Repository: mesos-git > > > Description > ------- > > See above. > > > Diffs > ----- > > src/master/master.hpp f567a4364e8edbf3a2f7bf5a3ebca45fbb64d252 > src/master/master.cpp 0335b3416ee1c4d14a70e018ad9174b465035c5f > src/tests/master_tests.cpp c429432b51ded9cdd7ac9abd5b4e98017c531d7e > > Diff: https://reviews.apache.org/r/20638/diff/ > > > Testing > ------- > > Added to the existing test. > > > Thanks, > > Ben Mahler > >
