----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20572/#review41306 -----------------------------------------------------------
Ship it! src/master/master.cpp <https://reviews.apache.org/r/20572/#comment74733> Any reason not to do this in this review? That way creating a master from 'cluster' and 'local' will also get this check. Seems like it's just an easy copy/paste IIUC. src/master/master.cpp <https://reviews.apache.org/r/20572/#comment74728> s/atleast/at least/ src/tests/mesos.hpp <https://reviews.apache.org/r/20572/#comment74730> s/MesoTest/MesosTest/ src/zookeeper/group.cpp <https://reviews.apache.org/r/20572/#comment74732> While I like giving lots of information for posterity, I'm not sure the ZooKeeper group should know anything about the log replicas so a LOG(WARNING) seems unnecessary. Ignoring non-sequence nodes is just a general safety mechanism that we happen to be exploiting in Mesos. ;-) - Benjamin Hindman On April 24, 2014, 1:10 a.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20572/ > ----------------------------------------------------------- > > (Updated April 24, 2014, 1:10 a.m.) > > > Review request for mesos, Ben Mahler, Jie Yu, and Jiang Yan Xu. > > > Bugs: MESOS-1226 > https://issues.apache.org/jira/browse/MESOS-1226 > > > Repository: mesos-git > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/Makefile.am 364d63bb1f5dc8b63f72693eafd0b2feec231d13 > src/local/local.cpp 297f35b7755a688a95e58777f7846aa0ff3e247f > src/master/constants.hpp 27ae4f89cfd1ddb7db287d650af160a690f93c26 > src/master/constants.cpp ed966bc5bcc4dbb0f96b966efe33f179723c6759 > src/master/flags.hpp c83292f10a488cf31c09d6917225704b77f3ee02 > src/master/main.cpp ec23781d2a1e687af031c060059de69079b179b4 > src/master/master.cpp 0335b3416ee1c4d14a70e018ad9174b465035c5f > src/state/log.hpp e25d1e5e1daf9a5a8cd6b7c6c9c95c38b58f892d > src/tests/balloon_framework_test.sh > f83240758b03871b8b53f45d0947c6171c9c3a93 > src/tests/cluster.hpp 1862fe89a6c5897755133232d133dbf3664ed10a > src/tests/mesos.hpp 7bc5e981a468b81f0460e2736c8d0b76518302de > src/tests/mesos.cpp a9844e4cfef2eecbb30ca4bf1fa59d62edf93569 > src/tests/registrar_zookeeper_tests.cpp PRE-CREATION > src/tests/script.cpp 09c7f3bfc8a4c3032116b90b44ca773deff4629d > src/zookeeper/group.cpp bdebc48e8ca793fa58cc0f9a0fc0daa5fb3a335e > > Diff: https://reviews.apache.org/r/20572/diff/ > > > Testing > ------- > > Added a new unit test that tests mesos cluster with registrar and zookeeper. > > Also, updated external tests to use log storage but without zookeeper. > > make check > > > Thanks, > > Vinod Kone > >
