----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20668/#review41332 -----------------------------------------------------------
Ship it! include/mesos/containerizer/containerizer.proto <https://reviews.apache.org/r/20668/#comment74753> I think we want s/task/task_info/ and s/executor/executor_info/. include/mesos/containerizer/containerizer.proto <https://reviews.apache.org/r/20668/#comment74766> Is this field actually being used? It seems like it existed originally because we weren't passing ExecutorInfo. Given the eventual API if only a TaskInfo is passed we won't have the FrameworkID (unless we also passed it in Containerizer::launch or added it to TaskInfo) and if we pass an ExecutorInfo it will have an optional FrameworkID, which makes this one seem redundant. I'd rather we didn't add it until we really needed it (so if deimos is somehow using it please correct me) especially since maybe the right thing to do is make it optional in TaskInfo? include/mesos/containerizer/containerizer.proto <https://reviews.apache.org/r/20668/#comment74755> For some external containerizer programs the Mesos libexec directory will also be valuable for other calls, such as Usage (to find mesos-usage) so rather than adding this to every protobuf let's make the ExternalContainerizer put this in the environment as MESOS_LIBEXEC_DIRECTORY just as it does for things like MESOS_DEFAULT_CONTAINER_IMAGE. - Benjamin Hindman On April 24, 2014, 5:22 p.m., Till Toenshoff wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20668/ > ----------------------------------------------------------- > > (Updated April 24, 2014, 5:22 p.m.) > > > Review request for mesos, Benjamin Hindman and Niklas Nielsen. > > > Repository: mesos-git > > > Description > ------- > > Updated Launch message to reflect latest commits on the TaskInfo related > containerizer Launch call/s. Renamed the Launch message attribute > "mesos_executor_path" to "mesos_libexec_directory" which will now hold the > libexec-path instead of the mesos-executor path directly - thus being usable > for other mesos provided executables (e.g. mesos-usage). > > Added Destroy, Wait and Usage messages to allow extending those messages in > the future, where needed. > > > Diffs > ----- > > include/mesos/containerizer/containerizer.proto 6ecd82e > > Diff: https://reviews.apache.org/r/20668/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Till Toenshoff > >
