----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20861/#review41762 -----------------------------------------------------------
Ship it! src/zookeeper/watcher.hpp <https://reviews.apache.org/r/20861/#comment75342> Can we add a comment above this class that highlights the importance of capturing the session ID? In particular, that queued messages might get "stale" with respect to the current ZooKeeper session. - Benjamin Hindman On April 29, 2014, 6:32 p.m., Jiang Yan Xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20861/ > ----------------------------------------------------------- > > (Updated April 29, 2014, 6:32 p.m.) > > > Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone. > > > Bugs: MESOS-1265 > https://issues.apache.org/jira/browse/MESOS-1265 > > > Repository: mesos-git > > > Description > ------- > > See the ticket for more information. > > > Diffs > ----- > > src/state/zookeeper.cpp a833eaa9f3addfb1dec8212ced6e5ec14feaf515 > src/zookeeper/group.hpp 7be9c22b00a458ea741b8f0edb719839b3d2467e > src/zookeeper/group.cpp 70972980dd25618c76eb36e0a31d060c096e36dc > src/zookeeper/watcher.hpp 2ddd2a566fbb07f75061b38aa269498b5d4c9044 > > Diff: https://reviews.apache.org/r/20861/diff/ > > > Testing > ------- > > make check. > No more tests are added because it would require us to 'freeze' the Group > while injecting more events. > > > Thanks, > > Jiang Yan Xu > >
