> On April 21, 2014, 4:01 p.m., Jie Yu wrote: > > 3rdparty/libprocess/src/http.cpp, line 66 > > <https://reviews.apache.org/r/20275/diff/2/?file=555469#file555469line66> > > > > Have you considered moving "contentType" to "headers" as well? > > Technically, it's one type of header. > > > > It also reads better: > > ... request(path, query, headers, body);
We had discussed this before and decided that since someone will often want to set the content type we'd pull it out as a shortcut. - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20275/#review40881 ----------------------------------------------------------- On April 12, 2014, 1:46 a.m., Benjamin Hindman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20275/ > ----------------------------------------------------------- > > (Updated April 12, 2014, 1:46 a.m.) > > > Review request for mesos, Ben Mahler and Jie Yu. > > > Repository: mesos-git > > > Description > ------- > > See summary (used in some upcoming reviews). > > > Diffs > ----- > > 3rdparty/libprocess/include/process/http.hpp > f85c06596ad7d9de4c2264ba1fbe13e8f1115f2c > 3rdparty/libprocess/src/http.cpp f8b93dc173a768db0bf4bd3b6413119581cf4f4c > 3rdparty/libprocess/src/tests/http_tests.cpp > 983e2a0a9009f6b9728d157756495f60b5ad76ea > > Diff: https://reviews.apache.org/r/20275/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Hindman > >
