----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20277/#review41805 -----------------------------------------------------------
Ship it! 3rdparty/libprocess/src/encoder.hpp <https://reviews.apache.org/r/20277/#comment75432> Maybe a comment as to why we do this check? 3rdparty/libprocess/src/process.cpp <https://reviews.apache.org/r/20277/#comment75431> Do we need to trim the header string? - Ben Mahler On April 30, 2014, 3:51 a.m., Benjamin Hindman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20277/ > ----------------------------------------------------------- > > (Updated April 30, 2014, 3:51 a.m.) > > > Review request for mesos, Ben Mahler, Jie Yu, Kevin Sweeney, and Brian > Wickman. > > > Repository: mesos-git > > > Description > ------- > > Enables using the 'libprocess-from' header as an alternative to 'User-Agent'. > > > Diffs > ----- > > 3rdparty/libprocess/src/encoder.hpp > 7f4593b808b2b14e9b178391d3923782e5428c64 > 3rdparty/libprocess/src/process.cpp > 26c16cf58c31102dc61b5844b3e4d75e5bc2764e > 3rdparty/libprocess/src/tests/process_tests.cpp > 745c3ada5f55722aed4adb4d0b1fcb16e4cb8e9b > > Diff: https://reviews.apache.org/r/20277/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Hindman > >
