----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20893/#review41847 -----------------------------------------------------------
Ship it! src/examples/python/test_containerizer.py <https://reviews.apache.org/r/20893/#comment75485> Not related to this commit, but where is the Environment from CommandInfo set for the command? src/examples/python/test_containerizer.py <https://reviews.apache.org/r/20893/#comment75486> Can you write the appropriate termination status when you destroy? then, wait will read that it's been destroyed, rather than having to infer it. src/examples/python/test_containerizer.py <https://reviews.apache.org/r/20893/#comment75477> how about "Container killed" src/examples/python/test_containerizer.py <https://reviews.apache.org/r/20893/#comment75478> termination status is optional - it should be set to none src/examples/python/test_containerizer.py <https://reviews.apache.org/r/20893/#comment75482> Can you be more descriptive in this message? Would ValueError be raised from line 327 with the int(status)? if so, you could say something like "Could not parse termination status" - Ian Downes On April 30, 2014, 8:36 a.m., Till Toenshoff wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20893/ > ----------------------------------------------------------- > > (Updated April 30, 2014, 8:36 a.m.) > > > Review request for mesos and Ian Downes. > > > Repository: mesos-git > > > Description > ------- > > A destroy on the container caused the wait-lock within test_containerizer.py > to result into a value-error when attempting to parse the exit-status. That > in turn caused the Wait result Future<Termination> to get failed, triggering > a crash within the new tear-down extensions within cluster.hpp. > > > Diffs > ----- > > src/examples/python/test_containerizer.py 7bebfee > > Diff: https://reviews.apache.org/r/20893/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Till Toenshoff > >
