> On April 30, 2014, 5:02 p.m., Dominic Hamon wrote: > > Can you give an example of the differences in time? Just to be sure that > > it's working and actually timing something ;)
Here are numbers for in_memory: "registrar/state_fetch_ms": 0.058846, "registrar/state_store_ms": 0.020012, "registrar/state_store_ms/count": 2, "registrar/state_store_ms/max": 0.028384, "registrar/state_store_ms/min": 0.020012, "registrar/state_store_ms/p50": 0.024198, "registrar/state_store_ms/p90": 0.0275468, "registrar/state_store_ms/p95": 0.0279654, "registrar/state_store_ms/p99": 0.02830028, "registrar/state_store_ms/p999": 0.028375628, "registrar/state_store_ms/p9999": 0.0283831628 For log_storage: "registrar/state_fetch_ms": 109.300277, "registrar/state_store_ms": 96.772123, "registrar/state_store_ms/count": 2, "registrar/state_store_ms/max": 96.772123, "registrar/state_store_ms/min": 16.301046, "registrar/state_store_ms/p50": 56.5365845, "registrar/state_store_ms/p90": 88.7250153, "registrar/state_store_ms/p95": 92.74856915, "registrar/state_store_ms/p99": 95.96741223, "registrar/state_store_ms/p999": 96.691651923, "registrar/state_store_ms/p9999": 96.7640758923 - Ben ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20897/#review41854 ----------------------------------------------------------- On April 30, 2014, 4:51 p.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20897/ > ----------------------------------------------------------- > > (Updated April 30, 2014, 4:51 p.m.) > > > Review request for mesos, Dominic Hamon and Vinod Kone. > > > Repository: mesos-git > > > Description > ------- > > This uses the new functionality from Timer to time only the State::fetch and > State::store operations, nothing more. > > > Diffs > ----- > > src/master/registrar.cpp 79d48912052cc223bf0e618763e8e47692c7c453 > > Diff: https://reviews.apache.org/r/20897/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Ben Mahler > >
