> On April 30, 2014, 5:16 p.m., Adam B wrote: > > 3rdparty/libprocess/3rdparty/stout/tests/base64_tests.cpp, line 1 > > <https://reviews.apache.org/r/20885/diff/1/?file=571406#file571406line1> > > > > Please add the standard copyright/license comment block at the top of > > each file.
Please do this for both files, thanks! > On April 30, 2014, 5:16 p.m., Adam B wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/base64.hpp, lines 10-14 > > <https://reviews.apache.org/r/20885/diff/1/?file=571405#file571405line10> > > > > Irregular comment style. I think we usually prefer // comments over > > /*block*/ comments Yup, use // over /*block*/ please. - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20885/#review41853 ----------------------------------------------------------- On April 30, 2014, 9 a.m., Isabel Jimenez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20885/ > ----------------------------------------------------------- > > (Updated April 30, 2014, 9 a.m.) > > > Review request for mesos, Adam B and Benjamin Hindman. > > > Bugs: MESOS-1131 > https://issues.apache.org/jira/browse/MESOS-1131 > > > Repository: mesos-git > > > Description > ------- > > 1st Phase following Ben's comments on https://reviews.apache.org/r/19575/ > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/Makefile.am 7faa562 > 3rdparty/libprocess/3rdparty/stout/include/stout/base64.hpp PRE-CREATION > 3rdparty/libprocess/3rdparty/stout/tests/base64_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/20885/diff/ > > > Testing > ------- > > > Thanks, > > Isabel Jimenez > >
