> On May 1, 2014, 3:06 p.m., Ben Mahler wrote: > > 3rdparty/libprocess/src/tests/metrics_tests.cpp, lines 289-319 > > <https://reviews.apache.org/r/20923/diff/1/?file=571903#file571903line289> > > > > It looks like this test is asserting that the timer names are valid > > ("_ms" and "_us" suffixes). I'm wondering why we couldn't just use > > Metric::name() to check the names in the existing Timer tests? (As opposed > > to adding this new test that makes http requests?)
it was also going to test the relative values of the timers but that won't be possible until the Clock change lands. Maybe it's worth adding this test then. - Dominic ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20923/#review41963 ----------------------------------------------------------- On May 1, 2014, 3:43 p.m., Dominic Hamon wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20923/ > ----------------------------------------------------------- > > (Updated May 1, 2014, 3:43 p.m.) > > > Review request for mesos, Benjamin Hindman and Ben Mahler. > > > Repository: mesos-git > > > Description > ------- > > see summary > > > Diffs > ----- > > 3rdparty/libprocess/include/process/metrics/timer.hpp > 26f997c0c5e034dab88cf59bb641754fec7b5abe > 3rdparty/libprocess/src/tests/metrics_tests.cpp > 75f1f0e35fdb1ec707785d1ebb903af99551bdaa > > Diff: https://reviews.apache.org/r/20923/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Dominic Hamon > >
