----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21017/#review42039 -----------------------------------------------------------
Ship it! src/master/master.cpp <https://reviews.apache.org/r/21017/#comment75783> Kill this. src/master/master.cpp <https://reviews.apache.org/r/21017/#comment75782> Update the log message. How about? LOG(INFO) << "Removing framework " << frameworkId << " from disconnected slave " << *slave << " because " << slave->info.checkpoint() ? "slave is not checkpointing" : "framework is not checkpointing"; - Vinod Kone On May 2, 2014, 6:20 p.m., Adam B wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21017/ > ----------------------------------------------------------- > > (Updated May 2, 2014, 6:20 p.m.) > > > Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone. > > > Bugs: MESOS-1264 > https://issues.apache.org/jira/browse/MESOS-1264 > > > Repository: mesos-git > > > Description > ------- > > Changed master to only remove a slave's frameworks and offers on exited, > not on reauthenticate. Still disconnects at the allocator in both cases. > > > Diffs > ----- > > src/master/master.hpp a6737d5 > src/master/master.cpp 8efa2c9 > > Diff: https://reviews.apache.org/r/21017/diff/ > > > Testing > ------- > > make check > ./bin/mesos-tests.sh > --gtest_filter=FaultToleranceTest.ReconcileIncompleteTasks --gtest_repeat=-1 > --gtest_break_on_failure > > > Thanks, > > Adam B > >
