> On May 1, 2014, 6:01 p.m., Vinod Kone wrote: > > 3rdparty/libprocess/src/reap.cpp, line 71 > > <https://reviews.apache.org/r/20971/diff/1/?file=572849#file572849line71> > > > > do we need errno == ECHILD check here?
You're correct, it's not necessary. If a child exits between the waitpid call and evaluating this conditional it will exist in Z; it'll be reaped on the next loop. Only reaped processes that *aren't* our children can satisfy this conditional. I've reworked the comments to make this logic clear(er). - Ian ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20971/#review41994 ----------------------------------------------------------- On May 1, 2014, 12:18 p.m., Ian Downes wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20971/ > ----------------------------------------------------------- > > (Updated May 1, 2014, 12:18 p.m.) > > > Review request for mesos, Ben Mahler and Vinod Kone. > > > Repository: mesos-git > > > Description > ------- > > See summary. > > > Diffs > ----- > > 3rdparty/libprocess/src/reap.cpp 274d1292a596c64de58e0b30e3d6a465bbf11e17 > > Diff: https://reviews.apache.org/r/20971/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Ian Downes > >
