----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21032/#review42079 -----------------------------------------------------------
Ship it! I'll add to the 'MasterTest.MetricsInStatsEndpoint' test to make sure it's there! src/master/master.hpp <https://reviews.apache.org/r/21032/#comment75824> s/length/size/ src/master/master.hpp <https://reviews.apache.org/r/21032/#comment75825> I will get this updated to use the protected 'events' in a locked section. - Ben Mahler On May 2, 2014, 9:15 p.m., Dominic Hamon wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21032/ > ----------------------------------------------------------- > > (Updated May 2, 2014, 9:15 p.m.) > > > Review request for mesos and Ben Mahler. > > > Repository: mesos-git > > > Description > ------- > > see summary > > > Diffs > ----- > > src/master/master.hpp 333e37ccd5746c5026740cfcb816499cea61a545 > src/master/master.cpp f205dca43f10697862e3fd3f435f1127a9d0aecb > > Diff: https://reviews.apache.org/r/21032/diff/ > > > Testing > ------- > > make check > > manual inspection of metrics endpoint > > > Thanks, > > Dominic Hamon > >
