----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20991/#review42078 -----------------------------------------------------------
Ship it! I'll get this committed with the changes below. 3rdparty/libprocess/include/process/process.hpp <https://reviews.apache.org/r/20991/#comment75823> This needs some locking, I chatted with benh around an alternative approach: -Expose 'events', 'lock()', 'unlock()' as protected. -In the Master, have the Gauge read 'events.size()' in a locked section. We were thinking about this, because there have been cases in the past where we wanted to introspect on the event queue. - Ben Mahler On May 2, 2014, 9:15 p.m., Dominic Hamon wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20991/ > ----------------------------------------------------------- > > (Updated May 2, 2014, 9:15 p.m.) > > > Review request for mesos, Benjamin Hindman and Ben Mahler. > > > Repository: mesos-git > > > Description > ------- > > see summary > > this will be used to allow Master and maybe Registrar to publish their > libprocess event queue size to metrics. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/process.hpp > d6bdccfccaad79cc9bc29f03a6cb9fa8550ccc64 > > Diff: https://reviews.apache.org/r/20991/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Dominic Hamon > >
