[ 
https://issues.apache.org/jira/browse/MESOS-1291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13989712#comment-13989712
 ] 

Dominic Hamon commented on MESOS-1291:
--------------------------------------

This should get us close to mesos-style - it requires clang-format 3.5 for a 
couple of the rules. We could start with clang-format 3.4 and get most of the 
way there though.

{noformat}
---
BasedOnStyle:  Chromium
AccessModifierOffset: -2
AllowShortFunctionsOnASingleLine: None # 3.5
BreakBeforeBraces: Linux
ConstructorInitializerIndentWidth: 2
DerivePointerBinding: false
ForEachMacros: [foreach, foreachkey, foreachpair, foreachvalue] #3.5
MaxEmptyLinesToKeep: 2
NamespaceIndentation: None
SpacesBeforeTrailingComments: 1
...
{noformat}


> Use clang-format to automatically format code to style
> ------------------------------------------------------
>
>                 Key: MESOS-1291
>                 URL: https://issues.apache.org/jira/browse/MESOS-1291
>             Project: Mesos
>          Issue Type: Improvement
>            Reporter: Dominic Hamon
>              Labels: style
>
> Instead of relying on a script to check and report style errors, we should 
> move to a workflow that allows people to write code how they feel comfortable 
> and then automatically format it to conform to our style guide.
> The Chromium style from clang-format 
> (http://clang.llvm.org/docs/ClangFormat.html) is very close to our style 
> except for the dropped braces on class, struct, and function definitions, and 
> two lines of whitespace between method definitions outside a class. As such, 
> we should consider adopting clang-format and patching it to include a Mesos 
> style variant.
> It can be run as part of post-reviews or as a git commit hook, or manually 
> from within editors.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to