[
https://issues.apache.org/jira/browse/MESOS-1243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13990079#comment-13990079
]
Ian Downes commented on MESOS-1243:
-----------------------------------
Can you clarify on why this is needed? I think it's a programming error and
indicates someone is confused if the slave tries to wait on a container that
the containerizer doesn't know about and thus it should be a Failure. I'd
rather fix the cause of the confusion.
Recovery:
The slave should recover a containerizer and pass all the containers it expects
should exist. The containerizer should return a failure if it's unable to
recover the requested container. The slave waits until recovery is succeeds so
it shouldn't try to wait on a container that wasn't recovered.
Launch:
I think it's a bug in the slave code where it tries to wait before the
container has successfully launched. If we correct this by moving the wait into
the successful launch code path then would this make this Option<Termination>
change unnecessary?
> Containerizer::wait return type should be Option<Termination>
> -------------------------------------------------------------
>
> Key: MESOS-1243
> URL: https://issues.apache.org/jira/browse/MESOS-1243
> Project: Mesos
> Issue Type: Improvement
> Reporter: Till Toenshoff
> Priority: Minor
> Labels: containerizer, external-containerizer, isolation, mesos,
> mesos-containerizer
>
> The containerizer {{wait}} should return an {{Option<Termination>}} to
> distinguish the case when it doesn't know about a {{ContainerID}}.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
