----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21052/#review42217 -----------------------------------------------------------
Ship it! include/mesos/mesos.proto <https://reviews.apache.org/r/21052/#comment76001> Do you also want to add optional data that should be in the response? include/mesos/mesos.proto <https://reviews.apache.org/r/21052/#comment76002> the default values for interval_seconds and timeout_seconds seem to indicate that 2 health checks could be in flight. is that intended? include/mesos/mesos.proto <https://reviews.apache.org/r/21052/#comment76003> +1 doesn't seem to belong here. also, s/does currently not/currently does not/ - Vinod Kone On May 3, 2014, 6:38 a.m., Benjamin Hindman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21052/ > ----------------------------------------------------------- > > (Updated May 3, 2014, 6:38 a.m.) > > > Review request for mesos, Niklas Nielsen and Vinod Kone. > > > Bugs: MESOS-741 > https://issues.apache.org/jira/browse/MESOS-741 > > > Repository: mesos-git > > > Description > ------- > > See summary. > > > Diffs > ----- > > include/mesos/mesos.proto e48e50aae248bd9d5289dbaa36753be53b2e592a > src/master/master.cpp c79fdafde6b08d74e6fea71afa79aded41b3a9ab > > Diff: https://reviews.apache.org/r/21052/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Hindman > >
