-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21091/
-----------------------------------------------------------

(Updated May 5, 2014, 11:36 p.m.)


Review request for mesos and Mesos ReviewBot.


Bugs: MESOS-1308
    https://issues.apache.org/jira/browse/MESOS-1308


Repository: mesos-git


Description
-------

Back-ports MESOS-1252 to add support ENV MAVEN_HOME on the build. This aids in 
the packaging of Mesos within a RHEL mock (chroot) environment.


Diffs
-----

  configure.ac 4f988a9dc8a332e4160e0c8979d43d0c73ba99fc 
  src/Makefile.am aa8bb2b492e4d37b14db294f48c074e631143b68 

Diff: https://reviews.apache.org/r/21091/diff/


Testing (updated)
-------

With MAVEN_HOME
1. ./bootstrap && mkdir build && cd build && MAVEN_HOME=/your/maven/path 
../configure  e.g. MAVEN_HOME=/usr/local/Cellar/maven/3.1.1/ ../configure
2. grep MAVEN_HOME Makefile
2.1 The MAVEN_HOME variable should be set with the correct MAVEN_HOME e.g. 
MAVEN_HOME = /usr/local/Cellar/maven/3.1.1/
3. grep MVN src/Makefile
3.1 The MVN variable should be set to the correct executable. e.g. MVN = 
/usr/local/Cellar/maven/3.1.1//bin/mvn
4. make -j 3 && make check
4.1 Java artifacts should be there.


Without MAVEN_HOME but with a MVN executable in your path.
1. ./bootstrap && mkdir build && cd build && ../configure
2. grep MAVEN_HOME Makefile
2.1 The MAVEN_HOME variable should be empty
3. grep MVN src/Makefile
3.1 The MVN variable should be set to the correct executable. e.g. check your 
mvn `which mvn`
4. make -j 3 && make check
4.1 Java artifacts should be there.


Thanks,

Bernardo Gomez Palacio

Reply via email to