-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19965/
-----------------------------------------------------------
(Updated May 6, 2014, 1:06 a.m.)
Review request for mesos, Benjamin Hindman and Dominic Hamon.
Changes
-------
Rebased to whitelist.
Bugs: MESOS-1181
https://issues.apache.org/jira/browse/MESOS-1181
Repository: mesos-git
Description (updated)
-------
Enabled whitespace/semicolon rule for cpplint, which covers the following logic:
# You should always have a space after a semicolon
# except for few corner cases
# You shouldn't have a space before a semicolon at the end of the line.
# There's a special case for "for" since the style guide allows space before
# the semicolon there.
Diffs (updated)
-----
src/tests/cgroups_tests.cpp 5f674cd
support/mesos-style.py bd7dcdb
Diff: https://reviews.apache.org/r/19965/diff/
Testing (updated)
-------
Ran mesos-style.py over entire source base with whitespace/semicolon enabled.
$ support/mesos-style.py
Checking 424 files using filter
--filter=-,+build/class,+build/deprecated,+build/endif_comment,+runtime/vlog,+whitespace/comma,+whitespace/ending_newline,+whitespace/forcolon,+whitespace/indent,+whitespace/line_length,+whitespace/semicolon,+whitespace/tab,+whitespace/todo
Total errors found: 0
Thanks,
Adam B
