-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19988/
-----------------------------------------------------------
(Updated May 6, 2014, 1:06 a.m.)
Review request for mesos, Benjamin Hindman and Ben Mahler.
Changes
-------
Rebased to cpplint whitelist and split off libprocess change into its own
review.
Bugs: MESOS-1181
https://issues.apache.org/jira/browse/MESOS-1181
Repository: mesos-git
Description
-------
Enabled readability/todo rule for cpplint, which covers the following:
'Missing username in TODO; it should look like "// TODO(my_username): Stuff."'
Used git blame to trace back the unaccredited TODOs, 3 to benh and 2 to bmahler.
bmahler's TODO in slave.cpp is already covered by one in messages.proto for
ReregisterSlaveMessage, so I removed it.
Diffs (updated)
-----
src/exec/exec.cpp 346e39f
src/master/master.cpp c79fdaf
src/sched/sched.cpp 3684cfe
src/slave/slave.cpp 2a48266
support/mesos-style.py bd7dcdb
Diff: https://reviews.apache.org/r/19988/diff/
Testing (updated)
-------
Ran mesos-style.py over entire source base with readability/todo enabled.
$ support/mesos-style.py
Checking 424 files using filter
--filter=-,+build/class,+build/deprecated,+build/endif_comment,+readability/todo,+runtime/vlog,+whitespace/comma,+whitespace/ending_newline,+whitespace/forcolon,+whitespace/indent,+whitespace/line_length,+whitespace/tab,+whitespace/todo
Total errors found: 0
Thanks,
Adam B
